Summary: | [EFL] Define to prevent a single backing-store application from calling the tiled view function. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JungJik Lee <jungjik.lee> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, hyuki.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
JungJik Lee
2012-02-05 17:52:48 PST
Created attachment 125548 [details]
proposal patch
Comment on attachment 125548 [details] proposal patch View in context: https://bugs.webkit.org/attachment.cgi?id=125548&action=review Looks OK. > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:396 > + No need for this extra line. > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:405 > + Ditto. Created attachment 125616 [details]
revised_patch_1
remove unnecessary lines.
Comment on attachment 125548 [details] proposal patch View in context: https://bugs.webkit.org/attachment.cgi?id=125548&action=review >> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:396 >> + > > No need for this extra line. done! >> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:405 >> + > > Ditto. done! LGTM. Comment on attachment 125616 [details] revised_patch_1 Rejecting attachment 125616 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 10594. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11439158 Created attachment 125770 [details]
revised_patch_2
Due to conflict with previous patch, I filed new rebased patch.
Comment on attachment 125770 [details] revised_patch_2 Clearing flags on attachment: 125770 Committed r106908: <http://trac.webkit.org/changeset/106908> All reviewed patches have been landed. Closing bug. |