Bug 77842

Summary:

[EFL] Define to prevent a single backing-store application from calling the tiled view function.

Product:

WebKit

Reporter:

JungJik Lee <jungjik.lee>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, hyuki.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
proposal patch	none
revised_patch_1	kling: review+, webkit.review.bot: commit-queue-
revised_patch_2	none

JungJik Lee

Reported 2012-02-05 17:52:48 PST

The define prevents an application using single backing store from calling tiled cache function. The tiled APIs opened to outer should check the view type before being called.

Attachments
proposal patch (3.80 KB, patch) 2012-02-05 18:01 PST, JungJik Lee	no flags	Details Formatted Diff Diff
revised_patch_1 (3.79 KB, patch) 2012-02-06 04:40 PST, JungJik Lee	kling: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
revised_patch_2 (3.88 KB, patch) 2012-02-06 22:59 PST, JungJik Lee	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

JungJik Lee

Comment 1 2012-02-05 18:01:51 PST

Created attachment 125548 [details] proposal patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2012-02-06 04:07:52 PST

Comment on attachment 125548 [details] proposal patch View in context: https://bugs.webkit.org/attachment.cgi?id=125548&action=review Looks OK. > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:396 > + No need for this extra line. > Source/WebKit/efl/ewk/ewk_view_tiled.cpp:405 > + Ditto.

JungJik Lee

Comment 3 2012-02-06 04:40:07 PST

Created attachment 125616 [details] revised_patch_1 remove unnecessary lines.

JungJik Lee

Comment 4 2012-02-06 04:40:43 PST

Comment on attachment 125548 [details] proposal patch View in context: https://bugs.webkit.org/attachment.cgi?id=125548&action=review >> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:396 >> + > > No need for this extra line. done! >> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:405 >> + > > Ditto. done!

KwangHyuk

Comment 5 2012-02-06 14:34:03 PST

LGTM.

WebKit Review Bot

Comment 6 2012-02-06 22:36:25 PST

Comment on attachment 125616 [details] revised_patch_1 Rejecting attachment 125616 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10594 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 10594. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11439158

JungJik Lee

Comment 7 2012-02-06 22:59:28 PST

Created attachment 125770 [details] revised_patch_2 Due to conflict with previous patch, I filed new rebased patch.

WebKit Review Bot

Comment 8 2012-02-06 23:22:50 PST

Comment on attachment 125770 [details] revised_patch_2 Clearing flags on attachment: 125770 Committed r106908: <http://trac.webkit.org/changeset/106908>

WebKit Review Bot

Comment 9 2012-02-06 23:22:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.