Bug 77840 – The scrolling tree should be aware of any wheel event handlers on the page

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

The scrolling tree should be aware of any wheel event handlers on the page

[Anders Carlsson]

Created attachment 125542 [details]
Patch

[WebKit Review Bot]

Comment on attachment 125542 [details]
Patch

Attachment 125542 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11432060

[Andreas Kling]

Comment on attachment 125542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125542&action=review

r=me with cr build fixed.

> Source/WebCore/page/scrolling/ScrollingTree.cpp:92
> +    if (scrollingTreeState->changedProperties() | ScrollingTreeState::WheelEventHandlerCount) {

You want & here.

[Andreas Kling]

<http://trac.webkit.org/changeset/106766>

[Andreas Kling]

http://trac.webkit.org/changeset/106767/trunk/Source/WebCore/dom/Document.cpp -> http://redct.info/reddit/ragefriends/requests/harpdarp.svg

[Raymond]

Comment on attachment 125542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125542&action=review

> Source/WebCore/dom/Document.cpp:5381
> +    UNUSED_PARAM(document)

On my machine this break build

UNUSED_PARAM(document) ->  UNUSED_PARAM(document);

While this can got build on buildbot?

[Raymond]

(In reply to comment #5)
> http://trac.webkit.org/changeset/106767/trunk/Source/WebCore/dom/Document.cpp -> http://redct.info/reddit/ragefriends/requests/harpdarp.svg

ok. I am late.

[Anders Carlsson]

Committed r106766: <http://trac.webkit.org/changeset/106766>