Bug 77839

Summary:

Web Inspector: Fix CallArgument type in Inspector.json

Product:

WebKit

Reporter:

Peter Rybin <prybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, prybin, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Peter Rybin

Reported 2012-02-05 16:09:46 PST

Currently CallArgument has the following field: { "name": "objectId", "$ref": "RemoteObject", "optional": true, "description": "Remote object handle." } The field name doesn't conform to field value type. Field type should be fixed to a correct "RemoteObjectId" which has always been expected in the InjectedScriptSource.js implementation. See also https://bugs.webkit.org/show_bug.cgi?id=74110

Attachments
Patch (3.63 KB, patch) 2012-02-05 16:19 PST, Peter Rybin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2012-02-05 16:15:21 PST

Inspector.json should be fixed. Inspector-0.1.json and Inspector-1.0.json should also be retroactively fixed.

Peter Rybin

Comment 2 2012-02-05 16:19:12 PST

Created attachment 125540 [details] Patch

WebKit Review Bot

Comment 3 2012-02-06 01:28:03 PST

Comment on attachment 125540 [details] Patch Clearing flags on attachment: 125540 Committed r106787: <http://trac.webkit.org/changeset/106787>

WebKit Review Bot

Comment 4 2012-02-06 01:28:08 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.