| Summary: | Remove mapped vs non-mapped attribute distinction. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | DOM | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2012-02-05 01:06:02 PST
Created attachment 125522 [details]
Possibly a patch
Comment on attachment 125522 [details]
Possibly a patch
r=me
Comment on attachment 125522 [details] Possibly a patch Clearing flags on attachment: 125522 Committed r106757: <http://trac.webkit.org/changeset/106757> All reviewed patches have been landed. Closing bug. > Previously, StyledElement would generate mapped
> attributes and plain Element would generate non-mapped ones.
Somehow I thought that mapped attributes were ones that were mapped to CSS (like "dir"), in contrast to ones like "onload". Was I horribly confused (at best)?
(In reply to comment #5) > > Previously, StyledElement would generate mapped > > attributes and plain Element would generate non-mapped ones. > > Somehow I thought that mapped attributes were ones that were mapped to CSS (like "dir"), in contrast to ones like "onload". Was I horribly confused (at best)? Yeah, I think both of us were. I suspect that was the intended meaning back in KHTML times. Mapped attributes have been coming out of StyledElement::createAttribute() and non-mapped ones from Element::createAttribute(). It made a bit more sense before Attribute and MappedAttribute were merged into one class by Anders (IIRC) some years ago, since before then only a MappedAttribute had a style declaration. |