Bug 77810

Summary: Web Inspector: beautify retaining tree items view
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 78411    
Attachments:
Description Flags
screenshot
none
Patch
none
Patch yurys: review+

Description Ilya Tikhonovsky 2012-02-04 05:41:03 PST 
%subj%
Comment 1 Ilya Tikhonovsky 2012-02-04 05:43:30 PST 
Created attachment 125494 [details]
screenshot
Comment 2 Ilya Tikhonovsky 2012-02-04 06:35:31 PST 
Created attachment 125496 [details]
Patch
Comment 3 Yury Semikhatsky 2012-02-04 23:42:01 PST 
Comment on attachment 125496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125496&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:399
> +            "        && (" + !this.showRetainingEdges + " || (!edge.isInternal && edge.nodeIndex !== 1))\n" +

I don't think we want to omit internal references like 'native' in the retainers path, some of them may be real retainers interesting for the user especially wheh there is no other retainer.  I think the condition should be more selective.
Comment 4 Ilya Tikhonovsky 2012-02-05 00:22:22 PST 
Created attachment 125519 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-02-05 00:27:25 PST 
Committed r106755: <http://trac.webkit.org/changeset/106755>