Bug 77798

Summary: Convert PopupMenuClient::clientPadding over to LayoutUnit
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, leviw, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Description Emil A Eklund 2012-02-03 19:01:00 PST
Change PopupMenuClient and all classes inheriting from it to use the new layout types for padding.
Comment 1 Emil A Eklund 2012-02-03 19:03:37 PST
Created attachment 125464 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-03 19:12:39 PST
Comment on attachment 125464 [details]
Patch

Attachment 125464 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11419573
Comment 3 Emil A Eklund 2012-02-03 20:15:06 PST
Created attachment 125472 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-02-03 21:20:45 PST
Comment on attachment 125472 [details]
Patch

This feels slightly odd, since I wouldn't expect most embedders to render popup menus with sub-pixel precision, but I guess with a scalable UI there is no reason why they wouldn't.
Comment 5 Emil A Eklund 2012-02-06 15:20:51 PST
All other paddings are being converted to LayoutUnit so it made sense to change this to be consistent. In all likelihood platforms will still return integer values though.
Comment 6 WebKit Review Bot 2012-02-06 17:08:20 PST
Comment on attachment 125472 [details]
Patch

Clearing flags on attachment: 125472

Committed r106880: <http://trac.webkit.org/changeset/106880>
Comment 7 WebKit Review Bot 2012-02-06 17:08:25 PST
All reviewed patches have been landed.  Closing bug.