Summary: | WebKit2 should dispatch wheel events to the new ScrollingTree class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2012-02-03 17:45:08 PST
Created attachment 125456 [details]
Patch
Attachment 125456 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/WebProcess/WebPage/EventDispatcher.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 125456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125456&action=review Ok. > Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:88 > + Whitespace. > Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:-111 > -#if ENABLE(THREADED_SCROLLING) > - MutexLocker locker(m_scrollingCoordinatorsMutex); > - if (ScrollingCoordinator* scrollingCoordinator = m_scrollingCoordinators.get(pageID).get()) { > - PlatformGestureEvent platformGestureEvent = platform(gestureEvent); > - > - if (scrollingCoordinator->handleGestureEvent(platformGestureEvent)) { > - sendDidHandleEvent(pageID, gestureEvent); > - return; > - } > - } > -#endif ChangeLog is missing a blurb about the removal of this hunk. Committed r106723: <http://trac.webkit.org/changeset/106723> |