WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
77795
WebKit2 should dispatch wheel events to the new ScrollingTree class
https://bugs.webkit.org/show_bug.cgi?id=77795
Summary
WebKit2 should dispatch wheel events to the new ScrollingTree class
Anders Carlsson
Reported
2012-02-03 17:45:08 PST
WebKit2 should dispatch wheel events to the new ScrollingTree class
Attachments
Patch
(11.66 KB, patch)
2012-02-03 17:46 PST
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2012-02-03 17:46:54 PST
Created
attachment 125456
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-03 17:49:20 PST
Attachment 125456
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/EventDispatcher.h:36: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3
2012-02-03 17:53:12 PST
Comment on
attachment 125456
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=125456&action=review
Ok.
> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:88 > +
Whitespace.
> Source/WebKit2/WebProcess/WebPage/EventDispatcher.cpp:-111 > -#if ENABLE(THREADED_SCROLLING) > - MutexLocker locker(m_scrollingCoordinatorsMutex); > - if (ScrollingCoordinator* scrollingCoordinator = m_scrollingCoordinators.get(pageID).get()) { > - PlatformGestureEvent platformGestureEvent = platform(gestureEvent); > - > - if (scrollingCoordinator->handleGestureEvent(platformGestureEvent)) { > - sendDidHandleEvent(pageID, gestureEvent); > - return; > - } > - } > -#endif
ChangeLog is missing a blurb about the removal of this hunk.
Anders Carlsson
Comment 4
2012-02-03 17:56:53 PST
Committed
r106723
: <
http://trac.webkit.org/changeset/106723
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug