| Summary: | Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, japhet, kling, macpherson, menard, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 77745 | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2012-02-03 14:20:39 PST
Created attachment 125413 [details]
patch
Attachment 125413 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/css/StylePropertySet.h:25: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/css/StylePropertySet.cpp:262: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebCore/css/StylePropertySet.cpp:543: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/css/StylePropertySet.cpp:562: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 4 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 125413 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=125413&action=review This patch doesn’t seem to have used “svn mv”. It would be nice to see the diffs between the code that was moved and how it looks in its new location, and if we use “svn mv” we would see that. > Source/WebCore/css/StylePropertySet.h:22 > +#ifndef CSSMutableStyleDeclaration_h > +#define CSSMutableStyleDeclaration_h Forgot to rename these. > Source/WebCore/css/StylePropertySet.h:24 > +#include "CSSStyleDeclaration.h" Should be able to get rid of this include eventually. (In reply to comment #3) > This patch doesn’t seem to have used “svn mv”. It would be nice to see the diffs between the code that was moved and how it looks in its new location, and if we use “svn mv” we would see that. Hmm, I used Xcode rename. Thought that would do svn mv. |