Summary: | configure: Two tests are displayed on the same line | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kalev Lember <kalevlember> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Kalev Lember
2012-02-03 11:37:57 PST
Created attachment 125373 [details]
configure: Print out the -Wno-c++0x-compat test result
The check whether -Wno-c++0x-compat flag is needed didn't print out
the test result (and newline), which caused the following test to be
displayed on the same line.
Comment on attachment 125373 [details] configure: Print out the -Wno-c++0x-compat test result View in context: https://bugs.webkit.org/attachment.cgi?id=125373&action=review > configure.ac:121 > -CXXFLAGS="$TMPCXXFLAGS", CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat") > +disable_cxx0x_compat=no, > +disable_cxx0x_compat=yes) > +AC_MSG_RESULT($disable_cxx0x_compat) > +if test "$disable_cxx0x_compat" = yes; then > + CXXFLAGS="$TMPCXXFLAGS -Wno-c++0x-compat" > +else > + CXXFLAGS="$TMPCXXFLAGS" > +fi Would it be sufficient here to simply add AC_MSG_RESULT Comment on attachment 125373 [details] configure: Print out the -Wno-c++0x-compat test result Clearing flags on attachment: 125373 Committed r106688: <http://trac.webkit.org/changeset/106688> All reviewed patches have been landed. Closing bug. |