Bug 77752

Summary:

Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository

Product:

WebKit

Reporter:

Xianzhu Wang <wangxianzhu>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
Sorry for uploading patch to wrong bug. Please ignore this.	none
Patch	none

Xianzhu Wang

Reported 2012-02-03 10:41:10 PST

<EOM>

Attachments
patch (41.17 KB, patch) 2012-02-03 10:43 PST, Xianzhu Wang	no flags	Details Formatted Diff Diff
Sorry for uploading patch to wrong bug. Please ignore this. (5.83 KB, text/plain) 2012-02-03 10:49 PST, Xianzhu Wang	no flags	Details
Patch (41.30 KB, patch) 2012-02-03 12:48 PST, Dirk Pranke	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Xianzhu Wang

Comment 1 2012-02-03 10:43:11 PST

Created attachment 125362 [details] patch

Xianzhu Wang

Comment 2 2012-02-03 10:49:19 PST

Created attachment 125364 [details] Sorry for uploading patch to wrong bug. Please ignore this. Thanks for suggestions. Not using ASSERT because I don't want the callers to know how viewport update and the main frame are related and to check it.

Dirk Pranke

Comment 3 2012-02-03 12:48:07 PST

Created attachment 125386 [details] Patch

Xianzhu Wang

Comment 4 2012-02-03 14:09:58 PST

(In reply to comment #3) > Created an attachment (id=125386) [details] > Patch Look good to me, but need r+ from some reviewer.

WebKit Review Bot

Comment 5 2012-02-03 15:53:41 PST

Comment on attachment 125386 [details] Patch Clearing flags on attachment: 125386 Committed r106702: <http://trac.webkit.org/changeset/106702>

WebKit Review Bot

Comment 6 2012-02-03 15:53:45 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.