Summary: | check-webkit-style is throwing an exception | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philip Rogers <pdr> | ||||
Component: | Tools / Tests | Assignee: | Ojan Vafai <ojan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, levin, ojan, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philip Rogers
2012-02-03 09:20:47 PST
Sounds like this is a regression from yesterday? Likely from Ojan's changes to speed up NRWT. Created attachment 125437 [details]
Patch
Comment on attachment 125437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313 > directories = itertools.chain.from_iterable(directory_lists) Would it make sense to make itertools.product return [] in this case, so every place that uses it just works when "not test_list"? (In reply to comment #4) > (From update of attachment 125437 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125437&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/webkit.py:313 > > directories = itertools.chain.from_iterable(directory_lists) > > Would it make sense to make itertools.product return [] in this case, so every place that uses it just works when "not test_list"? It might, but it's a python library, so... :) Comment on attachment 125437 [details] Patch Clearing flags on attachment: 125437 Committed r106735: <http://trac.webkit.org/changeset/106735> All reviewed patches have been landed. Closing bug. |