Bug 77727

Summary: [Qt] Building when a top directory is named Source
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, vestbo, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WorkAround
none
Patch none

Allan Sandfeld Jensen
Reported 2012-02-03 02:50:47 PST
Building webkit from an checkout of webkit into /mnt/fileserver/Source/webkit fails. The problem appears to be that the include path to generated files become /mnt/fileserver/webkit/Source/WebCore/generated (note the first 'Source' is missing). I have traced it to a setting ROOT_BUILD_DIR using $$replace. Using something more specific than $$replace would probably fix it, for instance only remove the last copy of SUBDIR.
Attachments
WorkAround (776 bytes, patch)
2012-03-13 10:07 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.53 KB, patch)
2012-06-05 05:26 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-03-13 10:07:46 PDT
Created attachment 131651 [details] WorkAround A workaround make replace act as replace only at end.
Tor Arne Vestbø
Comment 2 2012-03-13 11:04:52 PDT
Comment on attachment 131651 [details] WorkAround the part after OUT_PWD, is a regex, let's fix it by making the regexp right
Allan Sandfeld Jensen
Comment 3 2012-06-05 05:26:22 PDT
Created attachment 145767 [details] Patch
WebKit Review Bot
Comment 4 2012-06-05 08:13:56 PDT
Comment on attachment 145767 [details] Patch Clearing flags on attachment: 145767 Committed r119488: <http://trac.webkit.org/changeset/119488>
WebKit Review Bot
Comment 5 2012-06-05 08:14:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.