Bug 77714

Summary: Implement querySelector on ShadowRoot
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63601    
Attachments:
Description Flags
FAIL case
none
implement querySelector
none
Patch for landing none

Description Hayato Ito 2012-02-02 22:04:31 PST 
Now ShadowRoot inherits DocumentFragment both in WebCore and IDL, but it seems there is some cases that its querySelector APIs does not work correctly.
I'll attach a LayoutTest for error cases.
Comment 1 Hayato Ito 2012-02-02 22:09:45 PST 
Created attachment 125259 [details]
FAIL case
Comment 2 Hayato Ito 2012-02-06 01:25:18 PST 
Created attachment 125594 [details]
implement querySelector
Comment 3 Dimitri Glazkov (Google) 2012-02-06 09:10:35 PST 
Comment on attachment 125594 [details]
implement querySelector

View in context: https://bugs.webkit.org/attachment.cgi?id=125594&action=review

> Source/WebCore/dom/SelectorQuery.cpp:101
> +static inline bool nodeIsRootNodeOfTreeScope(Node* node)

seems too long of a name. Maybe isTreeScopeRoot?
Comment 4 Hayato Ito 2012-02-06 18:30:19 PST 
Thank you for the review.

(In reply to comment #3)
> (From update of attachment 125594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125594&action=review
> 
> > Source/WebCore/dom/SelectorQuery.cpp:101
> > +static inline bool nodeIsRootNodeOfTreeScope(Node* node)
> 
> seems too long of a name. Maybe isTreeScopeRoot?

Sounds good. Let me rename it and land this patch.
Comment 5 Hayato Ito 2012-02-06 18:36:11 PST 
Created attachment 125747 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-02-06 20:47:32 PST 
Comment on attachment 125747 [details]
Patch for landing

Clearing flags on attachment: 125747

Committed r106902: <http://trac.webkit.org/changeset/106902>
Comment 7 WebKit Review Bot 2012-02-06 20:47:38 PST 
All reviewed patches have been landed.  Closing bug.