Bug 77713

Summary: Add the "V8" prefix to V8 specific IDL attributes
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Severity: Normal CC: abarth, darin, japhet, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Description Flags
rebased patch for commit none

Description Kentaro Hara 2012-02-02 21:35:56 PST
We should add the "V8" prefix to a V8 specific IDL attribute, as follows:

[EnabledAtRuntime] => [V8EnabledAtRuntime]
Comment 1 Kentaro Hara 2012-02-02 21:40:46 PST
Created attachment 125258 [details]
Comment 2 Adam Barth 2012-02-03 00:57:17 PST
Comment on attachment 125258 [details]

We had a dream of implementing EnabledAtRuntime for JSC, but there doesn't seem to be overly much demand.
Comment 3 WebKit Review Bot 2012-02-03 03:32:36 PST
Comment on attachment 125258 [details]

Rejecting attachment 125258 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10576 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 10576.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11416288
Comment 4 Kentaro Hara 2012-02-03 07:18:14 PST
Created attachment 125321 [details]
rebased patch for commit
Comment 5 WebKit Review Bot 2012-02-03 08:53:27 PST
Comment on attachment 125321 [details]
rebased patch for commit

Clearing flags on attachment: 125321

Committed r106666: <http://trac.webkit.org/changeset/106666>