Bug 77708

Summary:

Add the "ObjC" prefix to ObjC specific IDL attributes

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, japhet, macpherson, menard, ojan, ossy, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

77393

Attachments:

Description	Flags
Patch	none
patch for commit	none
patch for commit	none
Patch	none

Kentaro Hara

Reported 2012-02-02 20:13:26 PST

We can add the "ObjC" prefix to ObjC specific IDL attributes, as follows: [Polymorphic] => [ObjCPolymorphic] [OldStyleObjC] => [ObjCOldStyle] [UsesView] => [ObjCUseDefaultView] (Note: Renamed for clarification)

Attachments
Patch (36.66 KB, patch) 2012-02-02 20:16 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
patch for commit (37.36 KB, patch) 2012-02-03 01:29 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
patch for commit (37.36 KB, patch) 2012-02-03 01:30 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (30.30 KB, patch) 2012-02-03 06:52 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-02-02 20:16:58 PST

Created attachment 125247 [details] Patch

Adam Barth

Comment 2 2012-02-03 00:51:05 PST

Comment on attachment 125247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125247&action=review > Source/WebCore/ChangeLog:11 > + [OldStyleObjC] => [ObjCOldStyle] I like all of these except perhaps this one. OldStyleObjC reads better to me. Is there something more descriptive we can say? ObjCLegacyInterface? I'll admit that "old style" has always been a mystery to me.

Kentaro Hara

Comment 3 2012-02-03 00:53:25 PST

(In reply to comment #2) > (From update of attachment 125247 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=125247&action=review > > > Source/WebCore/ChangeLog:11 > > + [OldStyleObjC] => [ObjCOldStyle] > > I like all of these except perhaps this one. OldStyleObjC reads better to me. Is there something more descriptive we can say? ObjCLegacyInterface? I'll admit that "old style" has always been a mystery to me. OK, then I'll rename it to ObjCLegacyInterface.

Adam Barth

Comment 4 2012-02-03 01:00:15 PST

> OK, then I'll rename it to ObjCLegacyInterface. That was just a guess at a name. I don't fully understand what the attribute does.

Adam Barth

Comment 5 2012-02-03 01:00:42 PST

Comment on attachment 125247 [details] Patch I'm going to mark this R+. I trust you to do something reasonable with OldStyleObjC.

Kentaro Hara

Comment 6 2012-02-03 01:07:41 PST

(In reply to comment #4) > > OK, then I'll rename it to ObjCLegacyInterface. > > That was just a guess at a name. I don't fully understand what the attribute does. As far as I see from the comments like "generate the old style method names with un-named parameters, these methods are deprecated" and "All deprecated methods\ need to be public, or should have the ObjCOldStyle IDL attribute removed", maybe the name would be [ObjCOldStyleMethod]. Thoughts? [OldStyleObjC] is not good since the name is not prefixed by "ObjC".

Adam Barth

Comment 7 2012-02-03 01:08:58 PST

ObjCLegacyUnamedParameters?

Kentaro Hara

Comment 8 2012-02-03 01:13:33 PST

(In reply to comment #7) > ObjCLegacyUnamedParameters? Yeah, this is more descriptive. +1.

Kentaro Hara

Comment 9 2012-02-03 01:29:22 PST

Created attachment 125288 [details] patch for commit

Kentaro Hara

Comment 10 2012-02-03 01:30:33 PST

Created attachment 125289 [details] patch for commit

WebKit Review Bot

Comment 11 2012-02-03 04:14:56 PST

Comment on attachment 125289 [details] patch for commit Clearing flags on attachment: 125289 Committed r106648: <http://trac.webkit.org/changeset/106648>

Csaba Osztrogonác

Comment 12 2012-02-03 06:24:18 PST

Reopen, because it broke the build on Mac.

Kentaro Hara

Comment 13 2012-02-03 06:52:13 PST

Created attachment 125319 [details] Patch

Kentaro Hara

Comment 14 2012-02-03 07:07:41 PST

Committed r106660: <http://trac.webkit.org/changeset/106660>

Note You need to log in before you can comment on or make changes to this bug.