Bug 77706

Summary:

Remove [LegacyParent] from CodeGeneratorGObject.pm, and rename it to [JSLegacyParent]

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, japhet, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

77393

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-02-02 19:43:18 PST

[LegacyParent] is a JSC-specific IDL attribute, and we can rename it to [JSLegacyParent]. Also, we need to remove dead code about [LegacyParent] from CodeGeneratorGObject.pm.

Comment 1 Kentaro Hara 2012-02-02 19:45:38 PST

Created attachment 125244 [details]
Patch

Comment 2 Adam Barth 2012-02-03 00:47:20 PST

Comment on attachment 125244 [details]
Patch

I think this rename names sense given that it's a legacy attribute.

Comment 3 Kentaro Hara 2012-02-03 00:51:21 PST

(In reply to comment #2)
> (From update of attachment 125244 [details])
> I think this rename names sense given that it's a legacy attribute.

Do you mean we should rename it better?

Comment 4 Adam Barth 2012-02-03 00:59:38 PST

> > I think this rename names sense given that it's a legacy attribute.
> 
> Do you mean we should rename it better?

I fail at typing.  I meant to say "I think this rename does make sense given that it's a legacy attribute."  :)

Comment 5 WebKit Review Bot 2012-02-03 01:55:10 PST

Comment on attachment 125244 [details]
Patch

Clearing flags on attachment: 125244

Committed r106639: <http://trac.webkit.org/changeset/106639>

Comment 6 WebKit Review Bot 2012-02-03 01:55:15 PST

All reviewed patches have been landed.  Closing bug.