Bug 77701

Summary: Remove OVERRIDE from ColorInputType::valueAsColor
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2012-02-02 18:26:22 PST
Remove OVERRIDE from ColorInputType::valueAsColor, it was a mistake.
Attachments
Patch (1.37 KB, patch)
2012-02-02 18:31 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (1.51 KB, patch)
2012-02-02 19:10 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-02-02 18:31:03 PST
Created attachment 125226 [details] Patch
Kent Tamura
Comment 2 2012-02-02 19:04:52 PST
Comment on attachment 125226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125226&action=review > Source/WebCore/html/ColorInputType.h:57 > - virtual Color valueAsColor() const OVERRIDE; > + virtual Color valueAsColor() const; Do we need virtual?
Keishi Hattori
Comment 3 2012-02-02 19:10:33 PST
Created attachment 125235 [details] Patch
Kent Tamura
Comment 4 2012-02-02 19:11:17 PST
Comment on attachment 125235 [details] Patch ok
WebKit Review Bot
Comment 5 2012-02-02 21:14:56 PST
Comment on attachment 125235 [details] Patch Clearing flags on attachment: 125235 Committed r106624: <http://trac.webkit.org/changeset/106624>
WebKit Review Bot
Comment 6 2012-02-02 21:15:00 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2012-02-07 12:39:12 PST
Hooray, this is just what OVERRIDE is for! Without OVERRIDE we probably would have had an unnecessary virtual function.
Note You need to log in before you can comment on or make changes to this bug.