Bug 7770

Summary:

Should only dispatch the khtmlTextInsertedEvent for high level editing operations

Product:

WebKit

Reporter:

Justin Garcia <justin.garcia>

Component:

HTML Editing

Assignee:

Justin Garcia <justin.garcia>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	adele: review+

Description Justin Garcia 2006-03-14 16:57:57 PST

The khtmlTextInsertedEvent is used to tell the new form fields that their inner div has been edited.  We don't need to tell them about every low level editing operation that we use to implement the higher level ones.  This also eliminates a big performance regression.

Comment 1 Justin Garcia 2006-03-14 16:58:50 PST

Created attachment 7068 [details]
patch

Comment 2 Adele Peterson 2006-03-14 17:03:50 PST

Comment on attachment 7068 [details]
patch

looks good! thanks for fixing this up.

Comment 3 Justin Garcia 2006-03-14 19:14:39 PST

We noticed that high level commands that go into an open TypingCommand don't go through EditCommand::apply, however they do go through appliedEditing/unappliedEditing/reappliedEditing on Frame, so that's where we dispatch.