Bug 7770

Summary: Should only dispatch the khtmlTextInsertedEvent for high level editing operations
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal CC: adele
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch adele: review+

Justin Garcia
Reported 2006-03-14 16:57:57 PST
The khtmlTextInsertedEvent is used to tell the new form fields that their inner div has been edited. We don't need to tell them about every low level editing operation that we use to implement the higher level ones. This also eliminates a big performance regression.
Attachments
patch (3.31 KB, patch)
2006-03-14 16:58 PST, Justin Garcia 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-03-14 16:58:50 PST
Created attachment 7068 [details] patch
Adele Peterson
Comment 2 2006-03-14 17:03:50 PST
Comment on attachment 7068 [details] patch looks good! thanks for fixing this up.
Justin Garcia
Comment 3 2006-03-14 19:14:39 PST
We noticed that high level commands that go into an open TypingCommand don't go through EditCommand::apply, however they do go through appliedEditing/unappliedEditing/reappliedEditing on Frame, so that's where we dispatch.
Note You need to log in before you can comment on or make changes to this bug.