Bug 77699

Summary: ColorInputType needs to use ensureInlineStyleDecl
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Keishi Hattori 2012-02-02 18:22:05 PST
Change ColorInputType to use ensureInlineStyleDecl.
Comment 1 Keishi Hattori 2012-02-02 19:07:57 PST
Created attachment 125234 [details]
Patch
Comment 2 Kent Tamura 2012-02-02 19:20:31 PST
Comment on attachment 125234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125234&action=review

> Source/WebCore/ChangeLog:7
> +        ColorInputType needs to use ensureInlineStyleDecl
> +        https://bugs.webkit.org/show_bug.cgi?id=77699
> +
> +        Reviewed by NOBODY (OOPS!).
> +

You had better add a reason that we need ensureInlineStyleDecl.
Comment 3 Keishi Hattori 2012-02-02 19:30:20 PST
Created attachment 125241 [details]
Patch
Comment 4 Keishi Hattori 2012-02-02 19:31:59 PST
Comment on attachment 125241 [details]
Patch

Added comment.

Because WebCore internally should use the more specific CSSMutableStyleDeclaration
http://trac.webkit.org/changeset/105739
Comment 5 WebKit Review Bot 2012-02-02 21:44:50 PST
Comment on attachment 125241 [details]
Patch

Clearing flags on attachment: 125241

Committed r106628: <http://trac.webkit.org/changeset/106628>
Comment 6 WebKit Review Bot 2012-02-02 21:44:54 PST
All reviewed patches have been landed.  Closing bug.