Bug 77691

Summary: Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use of device scale
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: PlatformAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, rakuco, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch trying to fix bots aestes: review+

Beth Dakin
Reported 2012-02-02 16:48:44 PST
Earlier this week in https://bugs.webkit.org/show_bug.cgi?id=77263 I fixed a bug where PlatformScreenMac was incorrectly relying on NSWindow. But in the process I introduced a layering violation, and just made WebKit2 do the same wrong thing as WebKit 1. Fix forthcoming. <rdar://problem/10754850>
Attachments
Patch (20.65 KB, patch)
2012-02-02 17:05 PST, Beth Dakin 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch trying to fix bots (20.33 KB, patch)
2012-02-02 17:44 PST, Beth Dakin 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-02-02 17:05:31 PST
Created attachment 125213 [details] Patch
Early Warning System Bot
Comment 2 2012-02-02 17:39:52 PST
Comment on attachment 125213 [details] Patch Attachment 125213 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11416070
Beth Dakin
Comment 3 2012-02-02 17:44:23 PST
Created attachment 125218 [details] Patch trying to fix bots
Beth Dakin
Comment 4 2012-02-03 11:30:03 PST
Thank Andy! Committed change: http://trac.webkit.org/changeset/106678
Note You need to log in before you can comment on or make changes to this bug.