Bug 77691

Summary:

Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use of device scale

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Platform

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, rakuco, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit-ews: commit-queue-
Patch trying to fix bots	aestes: review+

Description Beth Dakin 2012-02-02 16:48:44 PST

Earlier this week in https://bugs.webkit.org/show_bug.cgi?id=77263 I fixed a bug where PlatformScreenMac was incorrectly relying on NSWindow. But in the process I introduced a layering violation, and just made WebKit2 do the same wrong thing as WebKit 1. Fix forthcoming. 

<rdar://problem/10754850>

Comment 1 Beth Dakin 2012-02-02 17:05:31 PST

Created attachment 125213 [details]
Patch

Comment 2 Early Warning System Bot 2012-02-02 17:39:52 PST

Comment on attachment 125213 [details]
Patch

Attachment 125213 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11416070

Comment 3 Beth Dakin 2012-02-02 17:44:23 PST

Created attachment 125218 [details]
Patch trying to fix bots

Comment 4 Beth Dakin 2012-02-03 11:30:03 PST

Thank Andy! Committed change: http://trac.webkit.org/changeset/106678