Bug 77688

Summary: [chromium] add support for --makeargs to the ninja-based build
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2012-02-02 15:44:17 PST
[chromium] add support for --makeargs to the ninja-based build
Attachments
Patch (1.42 KB, patch)
2012-02-02 15:45 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2012-02-02 16:45 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-02-02 15:45:18 PST
Created attachment 125204 [details] Patch
jochen
Comment 2 2012-02-02 16:45:14 PST
Created attachment 125209 [details] Patch
jochen
Comment 3 2012-02-02 16:46:00 PST
Comment on attachment 125209 [details] Patch Removed the default -j flag, as requested by Nico, as ninja has a sensible default
WebKit Review Bot
Comment 4 2012-02-02 19:19:11 PST
Comment on attachment 125209 [details] Patch Clearing flags on attachment: 125209 Committed r106617: <http://trac.webkit.org/changeset/106617>
WebKit Review Bot
Comment 5 2012-02-02 19:19:15 PST
All reviewed patches have been landed. Closing bug.
Nico Weber
Comment 6 2012-02-03 15:29:49 PST
Thanks for the change, and for playing with ninja :-) Out of curiosity, what do you use this for?
jochen
Comment 7 2012-02-03 23:50:30 PST
To pass -j300 so ninja uses my incredible computing powah!
Note You need to log in before you can comment on or make changes to this bug.