Summary: | hasAttribute always returns false for uppercase attribute names like "STYLE" | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | cdumez | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Darin Adler
2006-03-14 09:14:41 PST
Created attachment 7061 [details]
patch with detailed change log and a layout test
<rdar://problem/4474884> hasAttribute always returns false for uppercase attribute names like "STYLE" Comment on attachment 7061 [details]
patch with detailed change log and a layout test
The new layout test "console" is neat.
"Did not raise an exception as expected" sounds ambiguous to me. I would say, "was expected to raise an exception but didn't" instead.
Am I right that lowercasedName is only actually lower case in the HTML case? Maybe we should just call it something like nameCopy instead.
r=me
Comment on attachment 7061 [details]
patch with detailed change log and a layout test
I find calling your local variable "lowercasedNamed" sorta odd, when half the time it's actually not lowercased.
You might consider calling it localName or name depending on which of those is already taken.
Oops, just call me "ggaren2". Mass moving XML DOM bugs to the "DOM" Component. |