Upstream targetType usage on ResourceRequest for BlackBerry port

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Rob Buis]

We rely on targetType usage, same as chromium port does.

[Rob Buis]

Created attachment 125145 [details]
Patch

[Antonio Gomes]

Comment on attachment 125145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125145&action=review

> Source/WebCore/platform/network/blackberry/ResourceRequest.h:53
> +        enum TargetType {
> +            TargetIsMainFrame,
> +            TargetIsSubframe,
> +            TargetIsSubresource, // Resource is a generic subresource. (Generally a specific type should be specified)
> +            TargetIsStyleSheet,
> +            TargetIsScript,
> +            TargetIsFontResource,
> +            TargetIsImage,
> +            TargetIsObject,
> +            TargetIsMedia,
> +            TargetIsWorker,
> +            TargetIsSharedWorker,
> +            TargetIsPrefetch,
> +            TargetIsPrerender,
> +            TargetIsFavicon,
> +            TargetIsXHR,
> +            TargetIsTextTrack,
> +            TargetIsUnspecified,
> +        };

maybe we should move it to the resourcerequestbase class, and only declare it for chromium and blackberry?

[Rob Buis]

(In reply to comment #2)
> (From update of attachment 125145 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125145&action=review
> 
> > Source/WebCore/platform/network/blackberry/ResourceRequest.h:53
> > +        enum TargetType {
> > +            TargetIsMainFrame,
> > +            TargetIsSubframe,
> > +            TargetIsSubresource, // Resource is a generic subresource. (Generally a specific type should be specified)
> > +            TargetIsStyleSheet,
> > +            TargetIsScript,
> > +            TargetIsFontResource,
> > +            TargetIsImage,
> > +            TargetIsObject,
> > +            TargetIsMedia,
> > +            TargetIsWorker,
> > +            TargetIsSharedWorker,
> > +            TargetIsPrefetch,
> > +            TargetIsPrerender,
> > +            TargetIsFavicon,
> > +            TargetIsXHR,
> > +            TargetIsTextTrack,
> > +            TargetIsUnspecified,
> > +        };
> 
> maybe we should move it to the resourcerequestbase class, and only declare it for chromium and blackberry?

This is a good idea, but would require feedback from Chromium folks. Note that our ResourceRequest implementation is different, for instance we add setAnchorText to the API, I am sure chromium adds other things.
Cheers,

Rob.

[Rob Buis]

Landed in r106655, closing.