Bug 77627

Summary: Web Inspector: enable editing of selected rows on single click in elements panel.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] Same with proper drag / context menu handling. vsevik: review+

Description Pavel Feldman 2012-02-02 04:36:59 PST
Single click on tag or attribute of the selected row will initiate editing.
Comment 1 Pavel Feldman 2012-02-02 04:41:10 PST
Created attachment 125114 [details]
Patch
Comment 2 Pavel Feldman 2012-02-02 05:17:20 PST
Created attachment 125119 [details]
[Patch] Same with proper drag / context menu handling.
Comment 3 Vsevolod Vlasov 2012-02-02 05:38:10 PST
Comment on attachment 125119 [details]
[Patch] Same with proper drag / context menu handling.

View in context: https://bugs.webkit.org/attachment.cgi?id=125119&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:998
> +        this._isSingleClickCandidate;

Please remove that.
Comment 4 Pavel Feldman 2012-02-02 06:28:57 PST
Committed r106552: <http://trac.webkit.org/changeset/106552>
Comment 5 Joseph Pecoraro 2012-02-02 10:38:23 PST
Would this make it harder to copy/paste from the tree outline?
I suppose "Right Click > Copy as HTML" will still be available.
Comment 6 Timothy Hatcher 2012-02-02 10:46:13 PST
To me the Elements tree would become a landmine, making it harder to select a node without having to press escape to cancel editing.
Comment 7 Pavel Feldman 2012-02-02 11:20:45 PST
(In reply to comment #6)
> To me the Elements tree would become a landmine, making it harder to select a node without having to press escape to cancel editing.

It only toggles editing in case you left-click on the selected row. I've spent some time playing with it and it did not make me angry. If it does annoy you, I'm ready to roll it out.

Btw, I landed an experiment that enables styles editing with single click. Also did not annoy me. Could you play with it?