Bug 77624

Summary: Web Inspector: add experiment for single click styles editing.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] with lint vsevik: review+

Pavel Feldman
Reported 2012-02-02 04:07:32 PST
Patch to follow.
Attachments
Patch (6.83 KB, patch)
2012-02-02 04:12 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] with lint (6.44 KB, patch)
2012-02-02 04:15 PST, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-02-02 04:12:29 PST
Created attachment 125106 [details] Patch
Pavel Feldman
Comment 2 2012-02-02 04:15:11 PST
Created attachment 125108 [details] [Patch] with lint
Alexander Pavlov (apavlov)
Comment 3 2012-02-02 04:52:21 PST
Comment on attachment 125108 [details] [Patch] with lint View in context: https://bugs.webkit.org/attachment.cgi?id=125108&action=review Looks good. Make sure this code works when a single-click in commits a selector and switches to editing a property name/value and vice versa. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1860 > + return element.enclosingNodeOrSelfWithClass("value"); return !!... to get the correct type
Pavel Feldman
Comment 4 2012-02-02 06:25:34 PST
Committed r106550: <http://trac.webkit.org/changeset/106550>
Note You need to log in before you can comment on or make changes to this bug.