Bug 77624

Summary: Web Inspector: add experiment for single click styles editing.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] with lint vsevik: review+

Description Pavel Feldman 2012-02-02 04:07:32 PST
Patch to follow.
Comment 1 Pavel Feldman 2012-02-02 04:12:29 PST
Created attachment 125106 [details]
Patch
Comment 2 Pavel Feldman 2012-02-02 04:15:11 PST
Created attachment 125108 [details]
[Patch] with lint
Comment 3 Alexander Pavlov (apavlov) 2012-02-02 04:52:21 PST
Comment on attachment 125108 [details]
[Patch] with lint

View in context: https://bugs.webkit.org/attachment.cgi?id=125108&action=review

Looks good.

Make sure this code works when a single-click in commits a selector and switches to editing a property name/value and vice versa.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1860
> +        return element.enclosingNodeOrSelfWithClass("value");

return !!... to get the correct type
Comment 4 Pavel Feldman 2012-02-02 06:25:34 PST
Committed r106550: <http://trac.webkit.org/changeset/106550>