Bug 77624 - Web Inspector: add experiment for single click styles editing.
Summary: Web Inspector: add experiment for single click styles editing.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-02-02 04:07 PST by Pavel Feldman
Modified: 2012-02-02 06:25 PST (History)
10 users (show)

See Also:

Patch (6.83 KB, patch)
2012-02-02 04:12 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] with lint (6.44 KB, patch)
2012-02-02 04:15 PST, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-02 04:07:32 PST
Patch to follow.
Comment 1 Pavel Feldman 2012-02-02 04:12:29 PST
Created attachment 125106 [details]
Comment 2 Pavel Feldman 2012-02-02 04:15:11 PST
Created attachment 125108 [details]
[Patch] with lint
Comment 3 Alexander Pavlov (apavlov) 2012-02-02 04:52:21 PST
Comment on attachment 125108 [details]
[Patch] with lint

View in context: https://bugs.webkit.org/attachment.cgi?id=125108&action=review

Looks good.

Make sure this code works when a single-click in commits a selector and switches to editing a property name/value and vice versa.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1860
> +        return element.enclosingNodeOrSelfWithClass("value");

return !!... to get the correct type
Comment 4 Pavel Feldman 2012-02-02 06:25:34 PST
Committed r106550: <http://trac.webkit.org/changeset/106550>