Bug 77621

Summary: Move remaining implementation from CSSStyleDeclaration to subclasses
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2012-02-02 03:50:54 PST
Clean sweep.
Attachments
patch (25.93 KB, patch)
2012-02-02 04:32 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-02-02 04:32:19 PST
Created attachment 125112 [details] patch
Andreas Kling
Comment 2 2012-02-02 09:54:58 PST
Comment on attachment 125112 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=125112&action=review > Source/WebCore/css/CSSMutableStyleDeclaration.h:129 > // CSSOM functions. Don't make these public. > + virtual CSSRule* parentRule() const; We should decorate the subclasses with OVERRIDE as appropriate.
Antti Koivisto
Comment 3 2012-02-02 10:09:13 PST
http://trac.webkit.org/changeset/106568
Note You need to log in before you can comment on or make changes to this bug.