Bug 77621 - Move remaining implementation from CSSStyleDeclaration to subclasses
Summary: Move remaining implementation from CSSStyleDeclaration to subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency treegraph
 
Reported: 2012-02-02 03:50 PST by Antti Koivisto
Modified: 2012-02-03 09:39 PST (History)
4 users (show)

See Also:


Attachments
patch (25.93 KB, patch)
2012-02-02 04:32 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-02-02 03:50:54 PST
Clean sweep.
Comment 1 Antti Koivisto 2012-02-02 04:32:19 PST
Created attachment 125112 [details]
patch
Comment 2 Andreas Kling 2012-02-02 09:54:58 PST
Comment on attachment 125112 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=125112&action=review

> Source/WebCore/css/CSSMutableStyleDeclaration.h:129
>      // CSSOM functions. Don't make these public.
> +    virtual CSSRule* parentRule() const;

We should decorate the subclasses with OVERRIDE as appropriate.
Comment 3 Antti Koivisto 2012-02-02 10:09:13 PST
http://trac.webkit.org/changeset/106568