Bug 77606

Summary:

The third argument of addEventListener/removeEventListener of PeerConnection should be optional

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

77393

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-02-01 23:18:17 PST

We need to correct typo in PeerConnection.idl:

Before:
void addEventListener(in DOMString type, in EventListener listener, in [optional] boolean useCapture);
void removeEventListener(in DOMString type, in EventListener listener, in [optional] boolean useCapture);

After:
void addEventListener(in DOMString type, in EventListener listener, in [Optional] boolean useCapture);
void removeEventListener(in DOMString type, in EventListener listener, in [Optional] boolean useCapture);

Comment 1 Kentaro Hara 2012-02-01 23:22:11 PST

Created attachment 125082 [details]
Patch

Comment 2 Adam Barth 2012-02-01 23:40:01 PST

Comment on attachment 125082 [details]
Patch

Thanks for the test.

Comment 3 WebKit Review Bot 2012-02-02 00:24:17 PST

Comment on attachment 125082 [details]
Patch

Clearing flags on attachment: 125082

Committed r106539: <http://trac.webkit.org/changeset/106539>

Comment 4 WebKit Review Bot 2012-02-02 00:24:24 PST

All reviewed patches have been landed.  Closing bug.