Bug 77604

Summary: [Qt] Inspector Disabled build breaks (if Javascript debugger is not disabled)
Product: WebKit Reporter: Sriram Neelakandan <sriram.neelakandan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: vestbo, webkit.review.bot, zoltan
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
patch to disable JS Debugger if Inspector is disabled
none
patch to disable JS Debugger if Inspector is disabled (with changeLog) none

Description Sriram Neelakandan 2012-02-01 22:36:30 PST 
I use the following command line to build-webkit-qt from Trunk (using Qt-4.8.0)

./Tools/Scripts/build-webkit --no-video --no-svg --no-mathml --no-inspector --no-3d-canvas --no-webkit2 --no-web-audio --debug --qt


The Inspector disabled build breaks with the following error:

../../../../Source/WebCore/bindings/js/ScriptProfiler.h:56:23: error: ‘InspectorValue’ was not declared in this scope
../../../../Source/WebCore/bindings/js/ScriptProfiler.h:56:37: error: template argument 1 is invalid


I think this may be due to http://trac.webkit.org/changeset/102366/trunk/Source/WebCore/bindings/js/ScriptProfiler.h

Attaching a patch to disable Javascript Debugger if Inspector is disabled in features.prf
Comment 1 Sriram Neelakandan 2012-02-01 22:37:46 PST 
Created attachment 125081 [details]
patch to disable JS Debugger if Inspector is disabled
Comment 2 Zoltan Horvath 2012-02-03 00:55:38 PST 
Looks reasonable for me. Please add changelog to the patch!
Comment 3 Sriram Neelakandan 2012-02-03 01:22:58 PST 
Created attachment 125285 [details]
patch to disable JS Debugger if Inspector is disabled (with changeLog)
Comment 4 Tor Arne Vestbø 2012-02-03 03:08:23 PST 
Comment on attachment 125285 [details]
patch to disable JS Debugger if Inspector is disabled (with changeLog)

thanks
Comment 5 WebKit Review Bot 2012-02-03 04:02:45 PST 
Comment on attachment 125285 [details]
patch to disable JS Debugger if Inspector is disabled (with changeLog)

Clearing flags on attachment: 125285

Committed r106647: <http://trac.webkit.org/changeset/106647>
Comment 6 WebKit Review Bot 2012-02-03 04:02:51 PST 
All reviewed patches have been landed.  Closing bug.