Bug 77586

Summary: [EFL] Add contentsSize flag into ewk_tiled_backing_store's private data.
Product: WebKit Reporter: KwangHyuk <hyuki.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch.
none
Patch updated.
none
Patch.
none
Patch updated.
none
Patch updated.
kling: review+, kling: commit-queue-
Patch. none

Description KwangHyuk 2012-02-01 17:28:22 PST
Created attachment 125051 [details]
Patch.

In order to prevent conflict between zoom and contents size change, layout flag is newly added.
Comment 1 WebKit Review Bot 2012-02-01 18:17:09 PST
Attachment 125051 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 KwangHyuk 2012-02-01 18:21:04 PST
Created attachment 125060 [details]
Patch updated.

Add bug ID.
Comment 3 WebKit Review Bot 2012-02-01 18:24:06 PST
Attachment 125060 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 KwangHyuk 2012-02-01 18:24:43 PST
Created attachment 125062 [details]
Patch.
Comment 5 Ryuan Choi 2012-02-02 17:20:47 PST
Comment on attachment 125062 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=125062&action=review

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1802
> +    priv->changed.layout = true;

I'm not good guys for the naming, but why don't you use contentsSize instead of layout ?

This flag looks to mark when contents resized.
Comment 6 KwangHyuk 2012-02-02 18:07:59 PST
Created attachment 125223 [details]
Patch updated.

Replace layout flag with contentsSize flag.
Comment 7 Ryuan Choi 2012-02-02 18:21:47 PST
(In reply to comment #6)
> Created an attachment (id=125223) [details]
> Patch updated.
> 
> Replace layout flag with contentsSize flag.

LGTM
Comment 8 KwangHyuk 2012-02-02 19:21:05 PST
Created attachment 125239 [details]
Patch updated.

Just move reset of contentsSize flag into existing condition block.
Comment 9 Andreas Kling 2012-02-02 20:00:30 PST
Comment on attachment 125239 [details]
Patch updated.

View in context: https://bugs.webkit.org/attachment.cgi?id=125239&action=review

r=me

> Source/WebKit/efl/ChangeLog:9
> +        ewk_tiled_bakcing_store can not detect the conflict between them.

Typo, ewk_tiled_backing_store.

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1377
> +        if (priv->changed.contentsSize)
> +            priv->changed.contentsSize = false;

No need for the "if" here, you could just do priv->changed.contentsSize = false; unconditionally.
Comment 10 KwangHyuk 2012-02-02 20:06:08 PST
(In reply to comment #9)
> (From update of attachment 125239 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125239&action=review
> 
> r=me
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        ewk_tiled_bakcing_store can not detect the conflict between them.
> 
> Typo, ewk_tiled_backing_store.
> 

Thanks. :)

> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1377
> > +        if (priv->changed.contentsSize)
> > +            priv->changed.contentsSize = false;
> 
> No need for the "if" here, you could just do priv->changed.contentsSize = false; unconditionally.

You are right.
Comment 11 KwangHyuk 2012-02-02 20:08:39 PST
Created attachment 125246 [details]
Patch.

Patch updated according to Kling's comment.
Comment 12 WebKit Review Bot 2012-02-02 21:42:30 PST
Comment on attachment 125246 [details]
Patch.

Clearing flags on attachment: 125246

Committed r106627: <http://trac.webkit.org/changeset/106627>
Comment 13 WebKit Review Bot 2012-02-02 21:42:35 PST
All reviewed patches have been landed.  Closing bug.