Summary: | contentDispositionType misparses the Content-Disposition header in some obscure corner cases | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, eric, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Adam Barth
2012-02-01 14:55:15 PST
Created attachment 125024 [details]
Patch
Comment on attachment 125024 [details]
Patch
I would like two additional pieces of information in your Changelog. 1. What happens w/o this patch. 2. How (if at all) this should affect Safari on Mac/Win.
Created attachment 125029 [details]
Patch
Comment on attachment 125029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125029&action=review > Source/WebCore/ChangeLog:24 > + Without this patch, these test cases neither trigger a navigation nor a > + download in Chromium. This patch does not appear to cause any visible > + change in Safari. (Safari passes these tests both before and after > + this patch.) You mentioned in person that *if* we saw a change it would be to cause more navigations to be treated as inline rather than downloads. Is that a correct restatement of our conversation? > You mentioned in person that *if* we saw a change it would be to cause more navigations to be treated as inline rather than downloads. Is that a correct restatement of our conversation?
Yes, but testing what actually happens in these cases shows that there isn't any difference in behavior. These cases appear to already treated as inline, even without this patch.
Comment on attachment 125029 [details]
Patch
OK. Thank you.
Comment on attachment 125029 [details]
Patch
Let's give AP a chance to comment. (He's in a metting ATM.)
Looks like this function isn't used by anyone except Chromium and Qt. Comment on attachment 125029 [details] Patch Clearing flags on attachment: 125029 Committed r106514: <http://trac.webkit.org/changeset/106514> All reviewed patches have been landed. Closing bug. |