Bug 77545

Summary: Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+

Description Antti Koivisto 2012-02-01 05:14:24 PST 
This is the easiest path for eliminating the last remaining subclass of CSSMutableStyleDeclaration.
Comment 1 Antti Koivisto 2012-02-01 05:35:33 PST 
Created attachment 124935 [details]
patch
Comment 2 Alexis Menard (darktears) 2012-02-01 05:51:30 PST 
Comment on attachment 124935 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124935&action=review

> Source/WebCore/dom/CSSMappedAttributeDeclaration.h:73
> +    RefPtr<CSSMutableStyleDeclaration> m_declaration;

Could this be a OwnPtr?
Comment 3 Antti Koivisto 2012-02-01 06:24:24 PST 
(In reply to comment #2)
> Could this be a OwnPtr?

No.
Comment 4 Andreas Kling 2012-02-01 08:21:42 PST 
Comment on attachment 124935 [details]
patch

r=me
Comment 5 Antti Koivisto 2012-02-01 09:43:38 PST 
http://trac.webkit.org/changeset/106471