Bug 77545

Summary: Make CSSMappedAttributeDeclaration have CSSMutableStyleDeclaration instead of being one
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2012-02-01 05:14:24 PST
This is the easiest path for eliminating the last remaining subclass of CSSMutableStyleDeclaration.
Attachments
patch (19.83 KB, patch)
2012-02-01 05:35 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-02-01 05:35:33 PST
Created attachment 124935 [details] patch
Alexis Menard (darktears)
Comment 2 2012-02-01 05:51:30 PST
Comment on attachment 124935 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=124935&action=review > Source/WebCore/dom/CSSMappedAttributeDeclaration.h:73 > + RefPtr<CSSMutableStyleDeclaration> m_declaration; Could this be a OwnPtr?
Antti Koivisto
Comment 3 2012-02-01 06:24:24 PST
(In reply to comment #2) > Could this be a OwnPtr? No.
Andreas Kling
Comment 4 2012-02-01 08:21:42 PST
Comment on attachment 124935 [details] patch r=me
Antti Koivisto
Comment 5 2012-02-01 09:43:38 PST
http://trac.webkit.org/changeset/106471
Note You need to log in before you can comment on or make changes to this bug.