Bug 77532

Summary: DFG should fold double-to-int conversions
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
none
the patch oliver: review+

Filip Pizlo
Reported 2012-02-01 01:47:40 PST
If a double-to-int conversion is using a constant, then don't emit code to convert the constant to an int. Just convert it in the compiler.
Attachments
the patch (32.51 KB, patch)
2012-02-01 01:50 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (32.51 KB, patch)
2012-02-01 01:55 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-02-01 01:50:44 PST
Created attachment 124908 [details] the patch
WebKit Review Bot
Comment 2 2012-02-01 01:52:44 PST
Attachment 124908 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/CodeBlock.h:728: The parameter name "v" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2012-02-01 01:55:21 PST
Created attachment 124909 [details] the patch Fixed style.
Filip Pizlo
Comment 4 2012-02-01 15:30:12 PST
Landed in http://trac.webkit.org/changeset/106502
Filip Pizlo
Comment 5 2012-02-06 17:34:38 PST
<rdar://problem/10817150>
Note You need to log in before you can comment on or make changes to this bug.