Bug 77532 - DFG should fold double-to-int conversions
Summary: DFG should fold double-to-int conversions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-01 01:47 PST by Filip Pizlo
Modified: 2012-02-06 17:34 PST (History)
1 user (show)

See Also:

Attachments
the patch (32.51 KB, patch)
2012-02-01 01:50 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (32.51 KB, patch)
2012-02-01 01:55 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-02-01 01:47:40 PST 
If a double-to-int conversion is using a constant, then don't emit code to convert the constant to an int.  Just convert it in the compiler.
Comment 1 Filip Pizlo 2012-02-01 01:50:44 PST 
Created attachment 124908 [details]
the patch
Comment 2 WebKit Review Bot 2012-02-01 01:52:44 PST 
Attachment 124908 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/bytecode/CodeBlock.h:728:  The parameter name "v" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-02-01 01:55:21 PST 
Created attachment 124909 [details]
the patch

Fixed style.
Comment 4 Filip Pizlo 2012-02-01 15:30:12 PST 
Landed in http://trac.webkit.org/changeset/106502
Comment 5 Filip Pizlo 2012-02-06 17:34:38 PST 
<rdar://problem/10817150>