Bug 77523

Summary:

[Chromium] Layout Test media/media-fragments/TC0080-TC0089.html is slow

Product:

WebKit

Reporter:

Yuzo Fujishima <yuzo>

Component:

Tools / Tests

Assignee:

Victoria Kirst <vrk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enne, eric.carlson, feature-media-reviews, fischman, jchaffraix, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Yuzo Fujishima

Reported 2012-02-01 01:25:25 PST

The following layout test is slow on WIN and MAC. media/media-fragments/TC0080-TC0089.html

Attachments
Patch (121.31 KB, patch) 2012-08-03 16:25 PDT, Ami Fischman	no flags	Details Formatted Diff Diff
Patch (121.02 KB, patch) 2012-08-03 22:03 PDT, Ami Fischman	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Chaffraix

Comment 1 2012-02-08 10:28:34 PST

It looks like this was never added to our test_expectations.txt. I just marked the test as SLOW on Windows Release as it has been timing out randomly and doesn't seem flaky on other platforms.

Adrienne Walker

Comment 2 2012-02-23 15:20:16 PST

Committed r108683: <http://trac.webkit.org/changeset/108683>

Adrienne Walker

Comment 3 2012-02-23 15:30:19 PST

OOPS.

Ami Fischman

Comment 4 2012-07-31 18:10:07 PDT

Same problem as bug 76967.

Ami Fischman

Comment 5 2012-08-03 16:25:08 PDT

Created attachment 156479 [details] Patch

Ami Fischman

Comment 6 2012-08-03 16:26:18 PDT

The new expectations are copied from the old ones, and the count of test cases (68) matches between the .js containing them and n-r-w-t's opinion of how many tests there are, so I think I managed to avoid messing up in the transition.

Eric Carlson

Comment 7 2012-08-03 16:35:20 PDT

Comment on attachment 156479 [details] Patch Setting r+, but waiting on the cq+ until the ews bots have had a chance to check it out.

WebKit Review Bot

Comment 8 2012-08-03 20:17:49 PDT

Comment on attachment 156479 [details] Patch Rejecting attachment 156479 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: TC0094.html patching file LayoutTests/media/media-fragments/media-fragments.js patching file LayoutTests/platform/chromium/TestExpectations Hunk #1 FAILED at 61. Hunk #2 FAILED at 2832. 2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/TestExpectations.rej patching file LayoutTests/platform/wk2/Skipped Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Carls..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13430626

Ami Fischman

Comment 9 2012-08-03 22:03:10 PDT

Created attachment 156512 [details] Patch

Ami Fischman

Comment 10 2012-08-03 22:03:44 PDT

Comment on attachment 156512 [details] Patch Rebased patch to HEAD.

WebKit Review Bot

Comment 11 2012-08-03 23:22:24 PDT

Comment on attachment 156512 [details] Patch Clearing flags on attachment: 156512 Committed r124690: <http://trac.webkit.org/changeset/124690>

WebKit Review Bot

Comment 12 2012-08-03 23:22:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.