Summary: | webkit-perf.appspot.com should accept test results without medians | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 77037, 77512 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2012-01-31 23:16:57 PST
Created attachment 124889 [details]
fixes the bug
Comment on attachment 124889 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review r=me. Sometime we should have test for this. > Websites/webkit-perf.appspot.com/report_handler.py:99 > + TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'), Considering TestResult.value is required field, this change looks reasonable. (In reply to comment #2) > (From update of attachment 124889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review > > r=me. Sometime we should have test for this. Yeah... Unfortunately, App Engine doesn't have any testing framework for python the last time I checked :( > > Websites/webkit-perf.appspot.com/report_handler.py:99 > > + TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'), > > Considering TestResult.value is required field, this change looks reasonable. Yes. In fact, _results_are_valid checks the existence of this value. Anyway thanks for the review! Landed as http://trac.webkit.org/changeset/106436. |