Paginated display does not respect page-break-{before,after}

• Component: WebKit API
• Status: RESOLVED FIXED

Paginated display does not respect page-break-{before,after}

<rdar://problem/10442663>

Created attachment 124967 [details]
Make RenderView pagination respect page-break properties by default and add API to make it respect column-break properties instead

[Darin Adler]

Comment on attachment 124967 [details]
Make RenderView pagination respect page-break properties by default and add API to make it respect column-break properties instead

View in context: https://bugs.webkit.org/attachment.cgi?id=124967&action=review

> Source/WebCore/rendering/RenderBlock.h:908
> +    virtual ColumnInfo::PaginationUnit paginationUnit();

Make this member function const?

> Source/WebCore/rendering/RenderView.cpp:209
> +    if (m_frameView) {
> +        if (Frame* frame = m_frameView->frame()) {
> +            if (Page* page = frame->page())
> +                return (frame == page->mainFrame() && page->pagination().behavesLikeColumns) ? ColumnInfo::Column : ColumnInfo::Page;
> +        }
> +    }

I think it would be nice to have a helper for the “page if this is the main frame of a page” logic. It’s repeated a few different places and it would be nice if it wasn’t.

Fixed in <http://trac.webkit.org/r106511>.