Bug 77463

Summary: [Chromium] Use SkCanvas::flush in skia port
Product: WebKit Reporter: Justin Novosad <junov>
Component: CanvasAssignee: Justin Novosad <junov>
Status: RESOLVED FIXED    
Severity: Normal CC: bsalomon, cc-bugs, dglazkov, jamesr, mdelaney7, reed, senorblanco, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Justin Novosad 2012-01-31 11:59:12 PST
In the skia platform code, we can eliminate direct dependencies on Ganesh APIs (GrContext in particular) in a few places places by using the recently added SkCanvas::flush method.  This will also make some parts of the code clearer and more concise.
Comment 1 Justin Novosad 2012-02-02 08:47:34 PST
Created attachment 125139 [details]
Patch
Comment 2 Brian Salomon 2012-02-02 08:52:38 PST
Yay!
Comment 3 WebKit Review Bot 2012-02-02 09:00:04 PST
Comment on attachment 125139 [details]
Patch

Attachment 125139 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11386855
Comment 4 Justin Novosad 2012-02-02 09:03:13 PST
Looks like I need a chromium DEPS roll

(In reply to comment #3)
> (From update of attachment 125139 [details])
> Attachment 125139 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11386855
Comment 5 Justin Novosad 2012-02-02 10:34:23 PST
Created attachment 125151 [details]
Patch
Comment 6 Stephen White 2012-02-02 12:00:45 PST
Comment on attachment 125151 [details]
Patch

Looks great!  Thanks for the cleanup.  r=me
Comment 7 WebKit Review Bot 2012-02-02 12:30:54 PST
Comment on attachment 125151 [details]
Patch

Rejecting attachment 125151 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
/graphics/chromium/cc/CCLayerTreeHostImpl.h
patching file Source/WebCore/platform/graphics/chromium/cc/CCProxy.h
patching file Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp
patching file Source/WebKit/chromium/DEPS
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Stephen Wh..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11381941
Comment 8 Justin Novosad 2012-02-02 12:46:40 PST
Created attachment 125162 [details]
Patch
Comment 9 Stephen White 2012-02-02 13:45:40 PST
Comment on attachment 125162 [details]
Patch

One mo' time!  r=me
Comment 10 WebKit Review Bot 2012-02-02 16:07:13 PST
Comment on attachment 125162 [details]
Patch

Clearing flags on attachment: 125162

Committed r106601: <http://trac.webkit.org/changeset/106601>
Comment 11 WebKit Review Bot 2012-02-02 16:07:18 PST
All reviewed patches have been landed.  Closing bug.