Summary: | [chromium] Expose windowResizerRectChanged() on WebWidget. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nico Weber <thakis> | ||||||
Component: | New Bugs | Assignee: | Nico Weber <thakis> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Nico Weber
2012-01-31 10:41:25 PST
Created attachment 124771 [details]
Patch
Attachment 124771 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.
When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".
rebase refs/remotes/origin/master: command returned error: 1
Died at Tools/Scripts/update-webkit line 164.
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 124771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124771&action=review R=me > Source/WebKit/chromium/public/WebWidget.h:188 > + virtual void windowResizerRectChanged() { } nit: please name this didChangeWindowResizerRect() to match naming conventions in the API. Created attachment 124773 [details]
Patch for landing
Comment on attachment 124773 [details] Patch for landing Clearing flags on attachment: 124773 Committed r106401: <http://trac.webkit.org/changeset/106401> All reviewed patches have been landed. Closing bug. |