Summary: | REGRESSION (r105908): WebKit1.InspectorBarTest is crashing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, enrica, webkit.review.bot | ||||
Priority: | P2 | Keywords: | PlatformOnly, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac (Intel) | ||||||
OS: | OS X 10.7 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2012-01-31 06:49:47 PST
I think I have a fix. Before r105908: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/2972 After r105908: http://build.webkit.org/builders/Lion%20Intel%20Debug%20%28Tests%29/builds/2973 Created attachment 124724 [details]
Only call -typingAttributes on WebViews, not WebHTMLViews
Attachment 124724 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.
When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".
rebase refs/remotes/origin/master: command returned error: 1
Died at Tools/Scripts/update-webkit line 164.
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 124724 [details]
Only call -typingAttributes on WebViews, not WebHTMLViews
r=me
Committed r106359: <http://trac.webkit.org/changeset/106359> |