Bug 77408

Summary: Web Inspector: boost protocol version to 1.0
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Pavel Feldman 2012-01-31 00:00:35 PST 
I think it is mature enough to have this sound name.
Comment 1 Pavel Feldman 2012-01-31 03:35:41 PST 
Created attachment 124701 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-31 03:38:21 PST 
Attachment 124701 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2012-01-31 03:49:53 PST 
Committed r106352: <http://trac.webkit.org/changeset/106352>
Comment 4 Timothy Hatcher 2012-01-31 07:16:28 PST 
Comment on attachment 124701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124701&action=review

> Source/WebCore/inspector/Inspector-1.0.json:124
> +                "hidden": true

Why are so many things still hidden if it is 1.0 worthy? We should really support most of these older hidden APIs at this point, especially if they didn't change much from version 0.1.