Bug 77408 – Web Inspector: boost protocol version to 1.0

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

I think it is mature enough to have this sound name.

[Pavel Feldman]

Created attachment 124701 [details]
Patch

[WebKit Review Bot]

Attachment 124701 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Committed r106352: <http://trac.webkit.org/changeset/106352>

[Timothy Hatcher]

Comment on attachment 124701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=124701&action=review

> Source/WebCore/inspector/Inspector-1.0.json:124
> +                "hidden": true

Why are so many things still hidden if it is 1.0 worthy? We should really support most of these older hidden APIs at this point, especially if they didn't change much from version 0.1.