Bug 77333

Summary: [chromium] remove exit time destructors from TextureManagerTest
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2012-01-30 05:27:59 PST
[chromium] remove exit time destructors from TextureManagerTest
Attachments
Patch (6.03 KB, patch)
2012-01-30 05:28 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (6.19 KB, patch)
2012-01-30 06:16 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-01-30 05:28:46 PST
Created attachment 124532 [details] Patch
Tony Gentilcore
Comment 2 2012-01-30 06:04:14 PST
Comment on attachment 124532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124532&action=review > Source/WebKit/chromium/ChangeLog:5 > + Recommend adding another line explaining "why". > Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h:54 > \ No newline at end of file The review tools makes this diff look strange. I assume you just added a newline?
jochen
Comment 3 2012-01-30 06:15:54 PST
(In reply to comment #2) > (From update of attachment 124532 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124532&action=review > > > Source/WebKit/chromium/ChangeLog:5 > > + > > Recommend adding another line explaining "why". done > > > Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h:54 > > \ No newline at end of file > > The review tools makes this diff look strange. I assume you just added a newline? right, the file had no new line at EOF which triggers a warning in clang (and isn't proper unix format)
jochen
Comment 4 2012-01-30 06:16:51 PST
Created attachment 124540 [details] Patch
WebKit Review Bot
Comment 5 2012-01-30 07:24:36 PST
Comment on attachment 124540 [details] Patch Clearing flags on attachment: 124540 Committed r106243: <http://trac.webkit.org/changeset/106243>
WebKit Review Bot
Comment 6 2012-01-30 07:24:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.