| Summary: | [chromium] remove exit time destructors from TextureManagerTest | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jamesr, wangxianzhu, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2012-01-30 05:27:59 PST
Created attachment 124532 [details]
Patch
Comment on attachment 124532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124532&action=review > Source/WebKit/chromium/ChangeLog:5 > + Recommend adding another line explaining "why". > Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h:54 > \ No newline at end of file The review tools makes this diff look strange. I assume you just added a newline? (In reply to comment #2) > (From update of attachment 124532 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124532&action=review > > > Source/WebKit/chromium/ChangeLog:5 > > + > > Recommend adding another line explaining "why". done > > > Source/WebKit/chromium/tests/FakeCCLayerTreeHostClient.h:54 > > \ No newline at end of file > > The review tools makes this diff look strange. I assume you just added a newline? right, the file had no new line at EOF which triggers a warning in clang (and isn't proper unix format) Created attachment 124540 [details]
Patch
Comment on attachment 124540 [details] Patch Clearing flags on attachment: 124540 Committed r106243: <http://trac.webkit.org/changeset/106243> All reviewed patches have been landed. Closing bug. |