Bug 77332

Summary: Node::parentOrHostElement(): Node::shadowHost() already returns an Element*
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: DOMAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Roland Steiner
Reported 2012-01-30 05:06:18 PST
In Node::parentOrHostElement(), the call to shadowHost() can only return an Element*, or 0. In the former case, the following test is unnecessary, while in the 0 case (if that should ever occur) it would crash.
Attachments
Patch (1.21 KB, patch)
2012-01-30 05:08 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2012-01-30 05:08:17 PST
Created attachment 124526 [details] Patch
Kent Tamura
Comment 2 2012-01-30 05:56:27 PST
Comment on attachment 124526 [details] Patch ok
WebKit Review Bot
Comment 3 2012-01-30 07:19:19 PST
Comment on attachment 124526 [details] Patch Clearing flags on attachment: 124526 Committed r106242: <http://trac.webkit.org/changeset/106242>
WebKit Review Bot
Comment 4 2012-01-30 07:19:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.