Summary: | Make GraphicsContext3DPrivate of GTK port shareable. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <kevin.cs.oh> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, igor.oliveira, jamesr, mrobinson, simon.fraser, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 77219 | ||||||||
Attachments: |
|
Description
ChangSeok Oh
2012-01-29 05:09:52 PST
Created attachment 124464 [details]
Patch
Comment on attachment 124464 [details]
Patch
We're just moving code here?
(In reply to comment #2) > (From update of attachment 124464 [details]) > We're just moving code here? Yes. But in the next patch, I plan to add some codes to support WebGL for EFL port based on this patch. Comment on attachment 124464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124464&action=review > Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h:41 > + public: > + static PassOwnPtr<GraphicsContext3DPrivate> create(); > + ~GraphicsContext3DPrivate(); > + bool makeContextCurrent(); > + > + private: Since the code is moving it might be a good idea to fix the indentation of "public:" and "private:" Created attachment 124490 [details]
Patch
Comment on attachment 124464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124464&action=review Thank you for review! >> Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h:41 >> + private: > > Since the code is moving it might be a good idea to fix the indentation of "public:" and "private:" Done. :) Comment on attachment 124490 [details]
Patch
rs=me.
Comment on attachment 124490 [details] Patch Clearing flags on attachment: 124490 Committed r106220: <http://trac.webkit.org/changeset/106220> All reviewed patches have been landed. Closing bug. |