Bug 77296

Summary: Make GraphicsContext3DPrivate of GTK port shareable.
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, igor.oliveira, jamesr, mrobinson, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77219    
Attachments:
Description Flags
Patch
none
Patch none

ChangSeok Oh
Reported 2012-01-29 05:09:52 PST
I think that GraphicsContext3DPrivate of GTK port could be shareable with another port using glx backend like EFL port.
Attachments
Patch (24.63 KB, patch)
2012-01-29 07:40 PST, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (24.62 KB, patch)
2012-01-29 20:53 PST, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2012-01-29 07:40:11 PST
Created attachment 124464 [details] Patch
Eric Seidel (no email)
Comment 2 2012-01-29 11:59:23 PST
Comment on attachment 124464 [details] Patch We're just moving code here?
ChangSeok Oh
Comment 3 2012-01-29 17:37:27 PST
(In reply to comment #2) > (From update of attachment 124464 [details]) > We're just moving code here? Yes. But in the next patch, I plan to add some codes to support WebGL for EFL port based on this patch.
Martin Robinson
Comment 4 2012-01-29 18:21:59 PST
Comment on attachment 124464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124464&action=review > Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h:41 > + public: > + static PassOwnPtr<GraphicsContext3DPrivate> create(); > + ~GraphicsContext3DPrivate(); > + bool makeContextCurrent(); > + > + private: Since the code is moving it might be a good idea to fix the indentation of "public:" and "private:"
ChangSeok Oh
Comment 5 2012-01-29 20:53:10 PST
Created attachment 124490 [details] Patch
ChangSeok Oh
Comment 6 2012-01-29 20:55:23 PST
Comment on attachment 124464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124464&action=review Thank you for review! >> Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h:41 >> + private: > > Since the code is moving it might be a good idea to fix the indentation of "public:" and "private:" Done. :)
Eric Seidel (no email)
Comment 7 2012-01-30 00:12:47 PST
Comment on attachment 124490 [details] Patch rs=me.
WebKit Review Bot
Comment 8 2012-01-30 01:40:52 PST
Comment on attachment 124490 [details] Patch Clearing flags on attachment: 124490 Committed r106220: <http://trac.webkit.org/changeset/106220>
WebKit Review Bot
Comment 9 2012-01-30 01:40:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.