|Product:||WebKit||Reporter:||Justin Garcia <justin.garcia>|
|Severity:||Normal||CC:||alice.barraclough, darin, ggaren, voyagesboothhelp|
|Priority:||P1||Keywords:||HasReduction, InRadar, Regression|
|OS:||OS X 10.4|
Description Justin Garcia 2006-03-11 16:40:36 PST
Goto: http://www.orbitz.com/ Click inside the text field for the "Leave" or "Return" date. A calendar should appear to let you chose a date graphically. It doesn't in TOT, but does in 10.4.5.
Comment 1 Justin Garcia 2006-03-11 16:41:50 PST
Oops, forgot an 'o' in "choose".
Comment 2 Alexey Proskuryakov 2006-03-12 02:37:58 PST
Created attachment 7019 [details] reduced test case
Comment 3 Alexey Proskuryakov 2006-03-12 02:53:29 PST
Created attachment 7020 [details] another test case Looks like two separate issues: 1) Firefox doesn't serialize onClick handler as an anonymous function, but WebKit does; 2) WebKit has lost the ability to parse such.
Comment 4 Darin Adler 2006-03-12 22:02:46 PST
Seems like (2) is by far the bigger issue.
Comment 5 Darin Adler 2006-03-13 09:23:44 PST
Comment 6 Darin Adler 2006-03-13 19:44:38 PST
Comment 7 Darin Adler 2006-03-13 21:19:56 PST
Comment 8 Darin Adler 2006-03-13 21:32:03 PST
Created attachment 7056 [details] patch that fixes the issues I called (a), (b), and (c)
Comment 9 Darin Adler 2006-03-13 21:35:50 PST
(In reply to comment #8) > Created an attachment (id=7056)  > patch that fixes the issues I called (a), (b), and (c) For performance, the "anonymous" should probably be added to the list in KJS_IDENTIFIER_EACH_PROPERTY_NAME_GLOBAL in identifier.h and then we should use anonymousPropertyName instead of "anonymous", which is annoying, since a function name is not really a property name.
Comment 10 Darin Adler 2006-03-14 04:31:23 PST
It's also possible that the name "anonymous" should appear in the serialized function, but should not be the function's name internally. Should do more testing to see if that's so.
Comment 11 Darin Adler 2006-03-14 04:35:05 PST
Comment 12 Darin Adler 2006-03-14 08:10:35 PST
Created attachment 7060 [details] patch that fixes the issues I called (a), (b), and (c)
Comment 14 Maciej Stachowiak 2006-03-22 20:51:10 PST
Code change looks good, but: 1) "It's also possible that the name "anonymous" should appear in the serialized function, but should not be the function's name internally. Should do more testing to see if that's so." Did you do this testing? 2) This needs test cases that cover the three issues you fixed. I am not sure what the deal is with (d), the parameter to Function should be a function body, not a function expression or declaration, I believe. r=me on the assumption that you address 1 and 2.
Comment 15 Darin Adler 2006-03-23 22:25:43 PST
(In reply to comment #14) > Code change looks good, but: > > 1) "It's also possible that the name "anonymous" should appear in the > serialized > function, but should not be the function's name internally. Should do more > testing to see if that's so." > > Did you do this testing? Turns out there's no such thing as "the function's name internally". The serialized form is the only place the function name shows up! > 2) This needs test cases that cover the three issues you fixed. I wrote test cases for (a) and (b).
Comment 16 Andrew Buston 2017-04-23 22:57:38 PDT