Summary: | Get rid of TransformOperationList | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Marrin <cmarrin> | ||||||||||
Component: | Layout and Rendering | Assignee: | Chris Marrin <cmarrin> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | igor.oliveira, noam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Chris Marrin
2012-01-27 15:08:55 PST
Created attachment 124382 [details]
Patch
TextureMapper uses fetchTransformOperationList, so it also needs to be changed. (In reply to comment #1) > Created an attachment (id=124382) [details] > Patch Comment on attachment 124382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124382&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:431 > + static int validateTransformOperations(const KeyframeValueList&, bool& hasBigRotation); The patch looks fine but I wish the name of this function better explained what its return value was. indexOfOperationsThatMatch() or some such. Created attachment 124393 [details]
Patch adding fix for TextureMapper
Created attachment 124399 [details]
Patch
(In reply to comment #5) > Created an attachment (id=124399) [details] > Patch TextureMapper changes look good to me! Comment on attachment 124399 [details] Patch Attachment 124399 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11359234 Created attachment 124408 [details]
Patch
Committed r106190: <http://trac.webkit.org/changeset/106190> Comment on attachment 124408 [details] Patch Cleared review? from attachment 124408 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). |