Bug 77249

Summary:

Get rid of TransformOperationList

Product:

WebKit

Reporter:

Chris Marrin <cmarrin>

Component:

Layout and Rendering

Assignee:

Chris Marrin <cmarrin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

igor.oliveira, noam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch adding fix for TextureMapper	none
Patch	none
Patch	none

Chris Marrin

Reported 2012-01-27 15:08:55 PST

This is a list generated by the GraphicsLayer::fetchTransformOperationList function. The real purpose of this function is to validate the transform operation lists in a keyframe animation. But it also generates a list of the operations themselves. The thing is, this list is already in the keyframes themselves. So it is not really needed and it will make it harder to add support for Filter animations.

Attachments
Patch (10.54 KB, patch) 2012-01-27 15:29 PST, Chris Marrin	no flags	Details Formatted Diff Diff
Patch adding fix for TextureMapper (13.41 KB, patch) 2012-01-27 16:17 PST, Chris Marrin	no flags	Details Formatted Diff Diff
Patch (15.59 KB, patch) 2012-01-27 16:46 PST, Chris Marrin	no flags	Details Formatted Diff Diff
Patch (16.08 KB, patch) 2012-01-27 17:43 PST, Chris Marrin	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Chris Marrin

Comment 1 2012-01-27 15:29:33 PST

Created attachment 124382 [details] Patch

Igor Trindade Oliveira

Comment 2 2012-01-27 15:35:26 PST

TextureMapper uses fetchTransformOperationList, so it also needs to be changed. (In reply to comment #1) > Created an attachment (id=124382) [details] > Patch

mitz

Comment 3 2012-01-27 15:46:11 PST

Comment on attachment 124382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124382&action=review > Source/WebCore/platform/graphics/GraphicsLayer.h:431 > + static int validateTransformOperations(const KeyframeValueList&, bool& hasBigRotation); The patch looks fine but I wish the name of this function better explained what its return value was. indexOfOperationsThatMatch() or some such.

Chris Marrin

Comment 4 2012-01-27 16:17:03 PST

Created attachment 124393 [details] Patch adding fix for TextureMapper

Chris Marrin

Comment 5 2012-01-27 16:46:49 PST

Created attachment 124399 [details] Patch

Noam Rosenthal

Comment 6 2012-01-27 16:53:59 PST

(In reply to comment #5) > Created an attachment (id=124399) [details] > Patch TextureMapper changes look good to me!

Early Warning System Bot

Comment 7 2012-01-27 17:16:53 PST

Comment on attachment 124399 [details] Patch Attachment 124399 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11359234

Chris Marrin

Comment 8 2012-01-27 17:43:47 PST

Created attachment 124408 [details] Patch

Chris Marrin

Comment 9 2012-01-28 11:02:49 PST

Committed r106190: <http://trac.webkit.org/changeset/106190>

Eric Seidel (no email)

Comment 10 2012-01-30 16:03:42 PST

Comment on attachment 124408 [details] Patch Cleared review? from attachment 124408 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.