Bug 77247

Summary: [chromium] Remove unnecessary retry logic in LayerRendererChromium initialization for accelerated painting
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
now with 50% more compilation kbr: review+

Description James Robinson 2012-01-27 14:39:35 PST 
[chromium] Remove unnecessary retry logic in LayerRendererChromium initialization for accelerated painting
Comment 1 James Robinson 2012-01-27 14:41:09 PST 
Created attachment 124371 [details]
Patch
Comment 2 Adrienne Walker 2012-01-27 14:46:27 PST 
Comment on attachment 124371 [details]
Patch

Looks good to me.  It's kind of awkward to use creation failure as a signal, and I can't see any reason to do that.
Comment 3 WebKit Review Bot 2012-01-27 14:49:20 PST 
Comment on attachment 124371 [details]
Patch

Attachment 124371 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11265858
Comment 4 James Robinson 2012-01-27 14:49:43 PST 
(In reply to comment #3)
> (From update of attachment 124371 [details])
> Attachment 124371 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11265858

Whoops, parenthesis are hard!
Comment 5 James Robinson 2012-01-27 15:13:31 PST 
Created attachment 124379 [details]
now with 50% more compilation
Comment 6 Kenneth Russell 2012-01-30 15:29:42 PST 
Comment on attachment 124379 [details]
now with 50% more compilation

Looks fine to me.
Comment 7 James Robinson 2012-01-30 17:23:24 PST 
Committed r106306: <http://trac.webkit.org/changeset/106306>